inbox-in-gmail icon indicating copy to clipboard operation
inbox-in-gmail copied to clipboard

Please add colour themes

Open Perifractic opened this issue 5 years ago • 5 comments

Inbox is great, but the interface was starting to look old. If you could add some colour theming options in time, it'd make this better than Inbox! Thanks for the great work.

Perifractic avatar Apr 23 '19 00:04 Perifractic

Somewhat related: if I remember right, @RedcoatAsher was planning on adding some form of Dark Mode theme.

russelldc avatar Apr 23 '19 05:04 russelldc

That would be a great start!

On Mon, Apr 22, 2019, 22:52 Daniel Russell [email protected] wrote:

Somewhat related: if I remember right, @RedcoatAsher https://github.com/RedcoatAsher was planning on adding some form of Dark Mode theme.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/boukestam/inbox-in-gmail/issues/58#issuecomment-485653304, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPFMUTSZPV4WXNJSSSGIYTPR2PZVANCNFSM4HHTVD6Q .

Perifractic avatar Apr 23 '19 06:04 Perifractic

We should also allow backgrounds, like Gmail. Those are selectable in the same section as color themes, in the settings gear icon at the top right -> Themes.

If you have a background image set now, it applies almost the same changes that break Gmail's built-in Dark theme. While the text of the email content doesn't turn white like Dark mode, some of the UI, like the left menu items get an ugly text shadow, and a majority of the toolbar on top of opened emails and the email list turn white.

To allow these to work out, we'd need to remove the gray background color from a lot of the elements, setting them to transparent instead.

russelldc avatar Apr 30 '19 08:04 russelldc

I've got a branch going here, very WIP: https://github.com/boukestam/inbox-in-gmail/tree/themes

A few problems to resolve:

  1. Gmail's default theme is white background, but I assume we'd want to default to Inbox-like gray
  2. Enforce black/dark text color on email list items (Icons, Subject, Author, Excerpt)
  3. Stop enforcing gray text on left menu, so Gmail can set that text to white when appropriate (Dark themes, backgrounds)
  4. Top bar should maybe be translucent or transparent, like Gmail, so the chosen color/background shows through

russelldc avatar Apr 30 '19 09:04 russelldc

One thing that makes this a bit difficult is that it seems like Gmail doesn't apply a certain class on theme-change, it just loads in a new css stylesheet entirely. So it's not obvious how to decide when the text and icons should be light or dark.

russelldc avatar Apr 30 '19 19:04 russelldc