Bartosz Oudekerk

Results 12 comments of Bartosz Oudekerk

I've added another commit which makes things a bit less ugly and allows us to log what was evaluated and how.

Even though functionally the same, I think doing it this way is a bit nicer. @gnustavo Could you please share your thoughts?

If #77 gets merged, this could easily be implemented by OR-ing CheckJira with a simple plugin that only succeeds if Jira is down, unresponsive, etc.

Thinking about this some more, I do wonder if adding this directive is the best solution. There's a plugin for parsing logs already, so with my proposed 'OR' feature, that...

I think for most cases this can already be achieved by combining the CheckJira and CheckLog plugins: ``` githooks.checkjira.matchkey=\b[A-Z][A-Z]+\d?-\d+\b githooks.checkjira.require=false githooks.checklog.title-match=(\b[A-Z][A-Z]+\d?-\d+\b)| ```

We are actually running into the issue where people seeing it the first time aren't clear about the issue. So if the specific solution in CheckJira would be considered, that...

I just tested it, and that would work great for us. Thanks! But I'm not sure skip-logs should have a default like that? It's good to have a sensible suggestion...

#78 Looks good to me. Regarding my PR #77. Are you doubtful about my chosen solution, or the way I implemented it? I know I'm not a developer, so it...

One thought I had was perhaps a separate property which could have a condition specifying which plugins should (or shouldn't?) match. Something like this for the above case: ``` githooks.checkjira1.matchkey=\b[A-Z][A-Z]+\d?-\d+\b...

Just realised that the initial config won't even work for us. It will check the key against both instances, so one will always fail. @gnustavo Do you see a solution?