Bottles icon indicating copy to clipboard operation
Bottles copied to clipboard

metainfo: Make sure not to translate the app name

Open ryonakano opened this issue 3 months ago • 3 comments

Description

This simple string "Bottles" is used in different contexts:

  • as a generic noun; referring to wine prefixes
  • as a proper noun, referring to the app name

Make sure not to make the app name translatable since it's a proper noun.

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

  • [ ] Run meson setup builddir --prefix=/usr -Ddevel=true
  • [ ] Run ninja -C builddir
  • [ ] Run ninja -C builddir bottles-pot
  • [ ] Open po/bottles.pot and see the msgid "Bottles" does not have data/com.usebottles.bottles.metainfo.xml.in as its occurrence:
1767 #: bottles/frontend/ui/list.blp:42 bottles/frontend/windows/main_window.py:200
1768 msgid "Bottles"
1769 msgstr ""

ryonakano avatar Apr 04 '24 14:04 ryonakano

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

fab-sonarqube[bot] avatar Apr 04 '24 15:04 fab-sonarqube[bot]

Pylint result on modfied files:

github-actions[bot] avatar Apr 04 '24 15:04 github-actions[bot]