Bottles
Bottles copied to clipboard
bottlesdevs
Add Kron4ek menu options for runners
Description
This is to enable https://github.com/bottlesdevs/components/pull/167
It adds a menu option for the Kron4ek Wine runners.
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
- Build Flatpak with provided JSON (had to remove the
tags out of the appdata file for it to fully build) - Clone https://github.com/keenanweaver/components/tree/kron4ek somewhere
- Launch with LOCAL_COMPONENTS=/path/to/clonedir flatpak run
- Download runners, apply to bottles, etc.
Were there any prior discussion to this? I'm converting this to draft for now.
Unsure! I'm just a guy trying to close issues. :)
Feel free to close if it is deemed out of scope.
Might be useful as we don’t offer a pure vanilla version of wine (our Vanilla runner still have the staging patchset). I think the name of the new category must be changed to help the user better understanding Its purpose.
Honestly, I feel like other runners aren't well explained either. There's a bit of fragmentation with runners.
I'm not completely sure about this: build_pkgs_unstable.yml
only advanced users should change runner, beginners must keep Soda which covers must cases.
Despite we try to improve Bottles, it's still need some knowledge in some areas when managing, runners and other components. I'll discuss this internally soon proposing my idea to fix the lack of knowledge.
Since there are a lot of runners in that collection, I think it's better to keep those runners in the Other section to avoid a giant loop.
Thanks for your contribution, I left a comment in the other MR too.