Bottles icon indicating copy to clipboard operation
Bottles copied to clipboard

frontend: Port to `AdwComboRow`

Open TheEvilSkeleton opened this issue 1 year ago • 4 comments

Description

This replaces GtkComboBoxes to AdwComboRow.

Closes https://github.com/bottlesdevs/Bottles/issues/454. Related to https://github.com/bottlesdevs/Bottles/issues/1598. Blocked by https://github.com/bottlesdevs/Bottles/pull/2043.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • [x] Locally

TheEvilSkeleton avatar Sep 09 '22 02:09 TheEvilSkeleton

We'll have to change Spinners because they create extra whitespace: image

TheEvilSkeleton avatar Sep 21 '22 21:09 TheEvilSkeleton

Why not set visible to false when the spinners aren't needed? it should get rid of that whitespace

axtloss avatar Sep 21 '22 21:09 axtloss

'Windows XP' appears in the OS picker twice

jannuary avatar Sep 22 '22 04:09 jannuary

Known issues:

  1. Clicking on bottle -> go back, clicking on bottle again leads to this error:
Traceback (most recent call last):
  File "/app/share/bottles/bottles/frontend/views/bottle_preferences.py", line 1002, in __set_windows
    value=win
UnboundLocalError: local variable 'win' referenced before assignment
  1. Setting to "Windows Vista" leads to this error:
02:14:48 (ERROR) Error while running async job: <bound method RegKeys.set_windows of <bottles.backend.wine.regkeys.RegKeys object at 0x7f9911b6ca90>>
	Exception: Given version is not supported.
 
  File "/app/share/bottles/bottles/frontend/utils/threading.py", line 63, in __target
    result = self.task_func(*args, **kwargs)
  File "/app/share/bottles/bottles/backend/wine/regkeys.py", line 35, in set_windows
    raise ValueError("Given version is not supported.")

TheEvilSkeleton avatar Sep 22 '22 06:09 TheEvilSkeleton

Known issues:

  1. Clicking on bottle, going back, and then clicking on bottle again makes "Windows Version" load infinitely, and we can't go back anymore.
  2. Setting to "Windows Vista" leads to this error:
02:14:48 (ERROR) Error while running async job: <bound method RegKeys.set_windows of <bottles.backend.wine.regkeys.RegKeys object at 0x7f9911b6ca90>>
	Exception: Given version is not supported.
 
  File "/app/share/bottles/bottles/frontend/utils/threading.py", line 63, in __target
    result = self.task_func(*args, **kwargs)
  File "/app/share/bottles/bottles/backend/wine/regkeys.py", line 35, in set_windows
    raise ValueError("Given version is not supported.")

TheEvilSkeleton avatar Sep 22 '22 15:09 TheEvilSkeleton