Bottles icon indicating copy to clipboard operation
Bottles copied to clipboard

fix: fix some appimage only bugs

Open cat-master21 opened this issue 2 years ago • 3 comments

Description

Fix's the appimage zsync not being uploaded to release and it fixs the release build by change mksquashfs name.

  • [ ] fix cabextract
  • [x] fix appimage generation on release builds

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

cat-master21 avatar Jun 16 '22 23:06 cat-master21

I'll keep this PR opened for the other appimage related problems, lilke the cabextract one

mirkobrombin avatar Jul 04 '22 07:07 mirkobrombin

Yeah I am trying to fix this issue by making it run by executing AppRun file which force points cabextract and others to rest of the libraries. Also appimage-builder (should) patches these.

cat-master21 avatar Jul 04 '22 16:07 cat-master21

I converted to draft to make it very clear that it is not finished. Feel free to mark it as review once finished.

TheEvilSkeleton avatar Jul 31 '22 13:07 TheEvilSkeleton

So I have been quite busy lately but here is a status report if anybody wants to pick it up. Wine doesn't work because it tries and manually find ld with a set path. This might be rpath do not know. I tried running the library patcher that appimage builder uses but still same issue.

cat-master21 avatar Sep 27 '22 01:09 cat-master21

I'm going to close this MR. I mentioned in the main AppImage thread at https://github.com/bottlesdevs/Bottles/issues/1272#issuecomment-1258904775 to let others know about it. Thanks for helping though! :heart:

TheEvilSkeleton avatar Sep 27 '22 03:09 TheEvilSkeleton