Bottles icon indicating copy to clipboard operation
Bottles copied to clipboard

Published 20 hours ago • verified publisher icon bottlesdevs

Some random improvements

Open A6GibKm opened this issue 2 years ago • 5 comments

I have yet to test all of these changes.

Some commits as Use GLib.compute_checksum instead of hashlib, file: Use g_format_size to get human readable size are not really needed but can make maintenance simpler.

A6GibKm avatar Apr 03 '22 13:04 A6GibKm

Is this MR planned to be worked at some point?

TheEvilSkeleton avatar Jul 31 '22 14:07 TheEvilSkeleton

Is this MR planned to be worked at some point?

Yes I rebased it and reviewed it.

A6GibKm avatar Jul 31 '22 15:07 A6GibKm

I also simplified it a bit.

A6GibKm avatar Jul 31 '22 15:07 A6GibKm

Wasn't there also file writing with GLib?

mirkobrombin avatar Jul 31 '22 17:07 mirkobrombin

I removed it, I might open a separate MR with it.

A6GibKm avatar Jul 31 '22 18:07 A6GibKm

Looks like there are conflicting files. Theoretically, once everything is resolved, it should be good to merge right?

TheEvilSkeleton avatar Aug 18 '22 04:08 TheEvilSkeleton

I was convinced I had already merged it actually

mirkobrombin avatar Aug 18 '22 06:08 mirkobrombin

@A6GibKm can you fix this once again? Really sorry for making you go through all this.

TheEvilSkeleton avatar Aug 20 '22 12:08 TheEvilSkeleton

I am on vacation, ill try to fix it this during next week!

A6GibKm avatar Aug 20 '22 16:08 A6GibKm

Enjoy! :)

TheEvilSkeleton avatar Aug 20 '22 18:08 TheEvilSkeleton

I rebased the MR, but I didn't have to update it really.

A6GibKm avatar Sep 17 '22 11:09 A6GibKm

I rebased the MR, but I didn't have to update it really.

Just github moment

mirkobrombin avatar Sep 17 '22 13:09 mirkobrombin

It happens, it is a bit more common in gitlab tho.

A6GibKm avatar Sep 17 '22 13:09 A6GibKm

Sad

mirkobrombin avatar Sep 17 '22 14:09 mirkobrombin