twoliter icon indicating copy to clipboard operation
twoliter copied to clipboard

add image prep functions to imghelper

Open jpculp opened this issue 1 year ago • 3 comments

Description of changes:

Adds or moves functionality around image name generation, compression, and decompression to imghelper.

Testing done:

  • Built aws-k8s-1.28
  • Repacked aws-k8s-1.28
  • Build vmware-k8s-1.28
  • Repacked vmware-k8s-1.28

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

jpculp avatar May 15 '24 18:05 jpculp

  • Split extensions from *_SUFFIX.
  • Adjusted wording on OVF error.
  • Cleaned up compress_image.
  • Unified decompress_image.
  • Dropped get_data_image for a later PR.

jpculp avatar May 17 '24 22:05 jpculp

  • Move FILENAME_PREFIX, SYMLINK_PREFIX, and the _IMAGE_NAMEs to imghelper
  • Limit scope of decompress_image to make it more consistent with compress_image
  • Remove VERSION_ID as an arg for symlink_image since we're already assuming it's in the environment and to make the inputs more consistent with compress_image and decompress_image.

jpculp avatar May 20 '24 23:05 jpculp

Rebased.

jpculp avatar May 21 '24 00:05 jpculp