bottlerocket icon indicating copy to clipboard operation
bottlerocket copied to clipboard

OOTB: Remove conditional compilation from logdog

Open jmt-lab opened this issue 1 year ago • 1 comments

What I'd like:

  • [ ] Check if there is model dependency on api server, if so remove it via transfer to configuration file
  • [ ] Check if there is conditional compilation #[cfg(..)] flags and if so remove them

Any alternatives you've considered:

jmt-lab avatar Feb 16 '24 19:02 jmt-lab

models is being used. Surely we can find a workaround for this:

note: required by a bound in `serde_json::from_str`
    --> /home/ANT.AMAZON.COM/brigmatt/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde_json-1.0.110/src/de.rs:2676:8
     |
2674 | pub fn from_str<'a, T>(s: &'a str) -> Result<T>
     |        -------- required by a bound in this function
2675 | where
2676 |     T: de::Deserialize<'a>,
     |        ^^^^^^^^^^^^^^^^^^^ required by this bound in `from_str`
help: consider specifying the generic argument
     |
201  |     serde_json::from_str::<T>(&response_body).context(error::SettingsJsonSnafu)
     |                         +++++

error[E0433]: failed to resolve: use of undeclared crate or module `model`
   --> logdog/src/log_request.rs:185:19
    |
185 |     let settings: model::Settings =
    |                   ^^^^^ use of undeclared crate or module `model`

error[E0433]: failed to resolve: use of undeclared crate or module `model`
   --> logdog/src/log_request.rs:195:35
    |
195 | async fn get_settings() -> Result<model::Settings> {
    |                                   ^^^^^ use of undeclared crate or module `model`

webern avatar Feb 16 '24 21:02 webern