bottlerocket icon indicating copy to clipboard operation
bottlerocket copied to clipboard

thar-be-updates: migrate to use configuration file

Open jmt-lab opened this issue 1 year ago • 3 comments

Issue number: #3625

Closes #3625

Description of changes:

This change migrates the thar-be-updates tool to utilize a configuration file at /etc/thar-be-updates.toml instead of calling back to the settings api.

log:

  • migration and template
  • migrate thar-be-updates tool to read settings from a config file

Testing done: Tested update from 1.18.0 -> 1.18.1 and ensured settings get populated appropriately

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

jmt-lab avatar Jan 19 '24 19:01 jmt-lab

fix build issue where i left unused imports

jmt-lab avatar Jan 19 '24 19:01 jmt-lab

  • Rebased off latest
  • Tested upgrade -> downgrade ensured everything is clean
  • Removed tokio dependency
  • Adjusted config_path use

jmt-lab avatar Feb 07 '24 20:02 jmt-lab

error: unused import: `PathBuf`
  --> api/thar-be-updates/src/status.rs:13:23
   |
13 | use std::path::{Path, PathBuf};
   |                       ^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_imports)]`

webern avatar Feb 08 '24 20:02 webern

updated on latest

jmt-lab avatar Feb 28 '24 22:02 jmt-lab

Fix the if condition around the boolean value causing it to not be rendered when false

jmt-lab avatar Mar 01 '24 19:03 jmt-lab

Updated per ben's comments, will begin testing now

jmt-lab avatar Mar 04 '24 18:03 jmt-lab