bottlerocket icon indicating copy to clipboard operation
bottlerocket copied to clipboard

Jmt/corndog/config file - Migrate corndog to use its own config file

Open jmt-lab opened this issue 1 year ago • 5 comments

Issue number: #3624

Closes #3624

Description of changes: Migrated corndog to read its settings from /etc/corndog.toml which is generated Added corndog-toml template Added migrations to ensure configuration file is seen both by services.sysctl and services.lockdown

Testing done: Tested migration and synchronization of config file

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

jmt-lab avatar Jan 18 '24 00:01 jmt-lab

Squashed the commits and performed testing on sysctl, was able to see the corndog.toml file get appropriately updated as well as the applied value using sysctl tool

jmt-lab avatar Jan 18 '24 22:01 jmt-lab

Rebased and made sure to update release verison in Twoliter.toml

jmt-lab avatar Jan 18 '24 22:01 jmt-lab

fixed build issue

jmt-lab avatar Jan 18 '24 23:01 jmt-lab

Rebased on latest and updated per comments. Also fully tested upgrade -> downgrade and works as expected

jmt-lab avatar Feb 07 '24 00:02 jmt-lab

Let's merge this first #3768 then rebase your PR to align on 1.19.2

webern avatar Feb 07 '24 21:02 webern

Updated on latest

jmt-lab avatar Feb 28 '24 22:02 jmt-lab

Fixed numerical order, will rerun test report to ensure it is accurate

jmt-lab avatar Mar 06 '24 22:03 jmt-lab