bottlerocket icon indicating copy to clipboard operation
bottlerocket copied to clipboard

build a better growpart

Open bcressey opened this issue 6 years ago • 1 comments

growpart has a number of rough edges at the moment.

If the GPT label is not at the end of the disk, the first run will not fully expand the partition. A second run will correct it, but this is awkward. (See #336 for more discussion.)

It only supports a partition as the input parameter, not the path to the underlying block device or disk image. It would be useful to handle this case as well, to simplify testing.

It only supports disks with a single partition, but it could also be defined to expand the last partition to fill the disk, to make it more generally useful.

bcressey avatar Oct 01 '19 20:10 bcressey

[moved from #333]

Would it be crazy to find an early header on a single-partition disk and move it to the end? (Or, more generally, a header with unused space after it.) So this could be done in one pass. I guess that'd mean kernel synchronization, but doable.

tjkirch avatar Oct 02 '19 17:10 tjkirch

Growpart is now gone, so I don't believe this is still an issue. Closing this as no longer needed, but feel free to reopen if anything further is needed. (@bcressey please reopen if this is not the case)

stmcginnis avatar Dec 05 '22 17:12 stmcginnis