bottlerocket icon indicating copy to clipboard operation
bottlerocket copied to clipboard

update to SDK v0.27.0

Open bcressey opened this issue 3 years ago • 2 comments

Issue number: Fixes #2419 Fixes #2418 Fixes #2175

Description of changes: Update to the latest SDK, from https://github.com/bottlerocket-os/bottlerocket-sdk/pull/82.

This adds two workarounds for new rpm behavior in Fedora 36, and syncs glibc and binutils with the versions found in the SDK. The version of Rust used for CI builds is also updated to match 1.63.0 in the SDK. The newer meson lets us update dbus-broker to v32, and requires some minor changes to iputils to drop unknown options.

The only controversial change may be the addition of -Bsymbolic-functions to the default linker flags. There's some light background reading here and here. The quick summary is that I don't really expect problems since we've been using -fno-semantic-interposition on the compiler side since 237946dc43e04b94f2aae429eaae16c71a520263, so it's hopefully just free performance at runtime from simplifying the dynamic linker's job. 🤞🏻

Testing done: Ran the quick tests for aws-* using testsys. Everything passed except for aws-k8s-1.20 on aarch64, which needs a custom conformance image, and aws-k8s-1.23, which needs a newer eksctl.

Verified that aws-k8s-1.22-nvidia still works.

TODO:

  • [ ] test vmware-k8s
  • [ ] test vmware-dev

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

bcressey avatar Sep 15 '22 22:09 bcressey

Force push above:

  • applies all the patches in glibc.spec
  • updates cargo-make as well
  • drops the clippy fix from 23255a829f96b6464ebf116b06d9f724ee1d17be

bcressey avatar Sep 22 '22 04:09 bcressey

Force push for a rebase to pull in the lint fix.

bcressey avatar Sep 22 '22 04:09 bcressey

Force push applies go fmt from Go 1.19.

bcressey avatar Sep 23 '22 02:09 bcressey