bottlerocket icon indicating copy to clipboard operation
bottlerocket copied to clipboard

Bottlerocket settings: Add data type / example for all configuration settings in Bottlerocket documentation (README)

Open RobertNorthard opened this issue 3 years ago • 1 comments

What I'd like:

Not all Bottlerocket settings in the readme provide examples. For example, for the following settings image-gc-low-threshold-percent, image-gc-high-threshold-percent it is not clear if the expected value is a string or integer, which can cause confusion during Bottlerocket configuration and result in time spent debugging. Please can this be made clearer for all settings values?

Any alternatives you've considered: N/A

RobertNorthard avatar Aug 08 '22 10:08 RobertNorthard

Thanks @RobertNorthard ! This is a good idea - we'll look into making that happen.

zmrow avatar Aug 08 '22 16:08 zmrow

I think the original concern has been addressed with the odd data types for some values with #2939, but it would be nice to have some clearer documentation around settings and their expected values.

@stockholmux do you think this would be good for the project-website?

stmcginnis avatar Mar 30 '23 20:03 stmcginnis

@stmcginnis That's fine although API documentation didn't make it into the first round of documentation. It will probably remain on the README for a while yet.

stockholmux avatar Mar 30 '23 21:03 stockholmux

I believe the current status is: "scalar values are strings unless otherwise noted" and the k8s-gc-threshold settings are the only ones otherwise noted.

webern avatar Mar 30 '23 23:03 webern

I think this is now addressed with all the work done in https://bottlerocket.dev/en/os/1.16.x/api/settings/ so closing this issue. If there is anything further missing there, please file an issue in the https://github.com/bottlerocket-os/bottlerocket-project-website repo.

stmcginnis avatar Nov 15 '23 21:11 stmcginnis