bottlerocket icon indicating copy to clipboard operation
bottlerocket copied to clipboard

allow setting max_container_log_line_size for containerd

Open rubroboletus opened this issue 2 years ago • 1 comments

What I'd like:

It will be really nice, when we will be able to set max_container_log_line_size value for containerd.

Any alternatives you've considered:

rubroboletus avatar Jul 22 '22 05:07 rubroboletus

Hi @rubroboletus , thanks for opening this issue. We'll take a look into supporting that.

etungsten avatar Jul 25 '22 22:07 etungsten

Looking at this now.

Since we may some day want to switch out our runtime from containerd to something else, we should keep these settings somewhat runtime agnostic, even if the specific setting is only applicable to containerd.

I am looking at adding:

  • settings.container-runtime.max-container-log-line-size: Controls how long container log messages can be. If the log output is longer than the limit, the log message will be broken into multiple lines.
  • settings.container-runtime.max-concurrent-downloads: Restricts the number of concurrent downloads for each image.

Testing out changes locally now. Will push up a PR soon.

stmcginnis avatar Oct 14 '22 19:10 stmcginnis