bottlerocket-update-operator icon indicating copy to clipboard operation
bottlerocket-update-operator copied to clipboard

Upgrades `kube-rs` to 0.75 and `k8s-openapi` to 0.16

Open jpmcb opened this issue 2 years ago • 0 comments

Ignores duplicate dependencies in the integration tests which are brought in via the aws config / sdk

Signed-off-by: John McBride <[email protected]>

Issue number:

This will close a few stale dependabot PRs automatically

Description of changes:

  • Upgrades kube-rs to 0.75 and k8s-openapi to 0.16. Upgrades a few methods to non-deprecated APIs in kube:
Deprecated since 0.74.0: 

ResourceExt::name can panic and has been replaced by ResourceExt::name_any and ResourceExt::name_unchecked.
This fn will be removed in 0.77.0.

Reference

Deprecated since 0.72.0: 

fn replaced with the WatchStreamExt::touched_objects which can be chained onto watcher.
Add use kube::runtime::WatchStreamExt; and call stream.touched_objects() instead.
This function will be removed in 0.75.0.

Reference

  • Also, since the integration tests is the only crate that's pulling in AWS dependencies, we can safely ignore the duplicate dependencies causing problems through the aws-smithy-client tree.

  • Finally, this patch also removes a few const variables that weren't being used and were throwing warnings during compile time

Testing done:

Coming soon!

Also, still need to verify that this works with creating IPv6 clusters (since there were comments about rustls-tls being tied in with kube 0.71 - @gthao313, do you have any insight on this? Or with how to test IPv6 clusters?)

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

jpmcb avatar Oct 14 '22 20:10 jpmcb