v12 icon indicating copy to clipboard operation
v12 copied to clipboard

[BUG] - Support for NodeJS 12 will soon end

Open laurentlp opened this issue 3 years ago • 5 comments

Describe the bug This isn't really a bug or even a feature but rather a simple reminder that the maintenance support for NodeJS 12 will expire on April 2022 and we should do something about it before then.

See this timeline: https://nodejs.org/en/about/releases/#releases

laurentlp avatar Jan 27 '22 22:01 laurentlp

Duplicate: botpress/v12#1308 (although this one here shows priorities more clearly since it is bug level to upgrade to 14, feature level to upgrade to 16)

JustusNBB avatar Feb 04 '22 15:02 JustusNBB

@laurentlp Is there an sort of timeline or update on this? Node 12 end-of-life was a few months ago.

https://github.com/botpress/v12/issues/1308

jlangree avatar Aug 03 '22 17:08 jlangree

I am having issues to install/build custom module dependencies now, because the module-builder force installs dependencies with disregard to engine restrictions. I've tried to open a ticket in problematic dependency repository, but it has been declined because of Node12 being out of support. I've tried to add dependency resolutions to tie down the problematic dependency - without success - I think it is the yarn --force the module-builder is doing (https://github.com/botpress/botpress/blob/master/build/module-builder/src/package.ts#L42). Still trying to fix this somehow without opening an additional ticket... at least here we have the root cause: Botpress' Node Version is out of support:

The engine "node" is incompatible with this module. Expected version ">= 14". Got "12.22.10"

Edit: I was now able to tie down dependency versions using the "resolutions" field in the module's package.json (fixing it in an intermediate package.json did not help).

Please update Botpress to Node14/16 so these dependency issues do not become daily business!!

JustusNBB avatar Aug 22 '22 13:08 JustusNBB

@JustusNBB Can you please elaborate on what steps did you take to get the node version upgraded? Which OS are you trying to build the project on?

Yaminiag avatar Dec 05 '22 15:12 Yaminiag

@JustusNBB Can you please elaborate on what steps did you take to get the node version upgraded? Which OS are you trying to build the project on?

Sorry but I can't tell you anymore and I don't think these questions are relevant here. Ubuntu is usually used as a base image for Botpress. You can try Alpine too, and/or Node Version Manager!

@laurentlp any updates? It's "support has ended half a year ago" now.

JustusNBB avatar Dec 05 '22 15:12 JustusNBB