Theo Buehler

Results 133 comments of Theo Buehler

On second thought, this is just nonsense: https://pubs.opengroup.org/onlinepubs/7908799/xsh/pthread_mutex_init.html

@testuser220 thanks for the follow-up. That there are leaks due to the compat implementation and due to missing cleanup in `OpenSSL_cleanup()`, I can believe.

You should be able to replace it with https://man.openbsd.org/EVP_read_pw_string

The PKCS#8 part of this is now fixed and this will also fix a few things in PKCS#7. We may need to look into doing RFC 9579 or RFC 9579bis....

On Tue, Aug 06, 2024 at 02:18:34AM -0700, LainOTN2 wrote: > Tested on OpenSSH portable, and it fixes the issues on Win32 builds. Many thanks for testing! I'll see how...

On Mon, Oct 07, 2024 at 08:22:28PM -0700, Brent Cook wrote: > Going to land this now Thanks. Sorry, didn't get around to reviewing it yesterday. Looks good to me.

> https://github.com/yhirose/cpp-httplib/blob/v0.16.0/httplib.h#L9032 > > Is it possible that LibreSSL can add `SSL_get1_peer_certificate` in the future? Or is there a better way to avoid this? It would be easy to add...

> It seems in OpenBSD the `ccache` package uses the vendored copy of `cpp-httplib`which doesn't have this problem (Yet?). The OpenBSD port does use the bundled cpp-httplib version which appears...

Since this is a header only library, CXX flags won't work. I would probably work around this this by adding something like #if defined(LIBRESSL_VERSION_NUMBER) #define SSL_get1_peer_certificate SSL_get_peer_certificate #endif and see...

> subject=/C=US/ST=Test State or Province/L=Test Locality/O=Organization Name/OU=Organizational Unit Name/CN=Common ***@***.*** > openssl req -x509 -config test.conf -key key.pem -sha256 -days 3650 -nodes -out cert2.pem -extensions SAN > unable to load...