s3transfer icon indicating copy to clipboard operation
s3transfer copied to clipboard

added Tagging and TaggingDirective to ALLOWED_UPLOAD_ARGS

Open rvrangel opened this issue 6 years ago • 7 comments

Related to Issue #94 and PR #96

Looks like that PR hasn't been updated in more than a year, so I am creating a new one to add Tagging and TaggingDirective to S3Transfer and also including the change on __init__.py.

rvrangel avatar Oct 07 '19 17:10 rvrangel

Please pull the MR, I have been waiting 16 days now ^^ :)

cAS666666 avatar Oct 23 '19 19:10 cAS666666

I approve of this. Please make it happen asap. I don't want to upload an object and THEN add a tag..

LeJerk avatar Oct 23 '19 19:10 LeJerk

+1

chongchongu avatar Oct 25 '19 20:10 chongchongu

Any update on this? Would love to see this get merged

rvrangel avatar Dec 04 '19 15:12 rvrangel

@rvrangel Thanks for the pull request and sorry about the delay here! I looked over the PR and it looked good. There was an edge case that needed to be added related to filtering out TaggingDirective from multipart copies. So I pulled in your commit, rebased it with the latest commits on develop, and fixed that edge case in this PR: https://github.com/boto/s3transfer/pull/155. This PR should be reviewed and merged shortly.

kyleknap avatar Jan 15 '20 00:01 kyleknap

Thanks @kyleknap, really appreciate it 🙇

rvrangel avatar Jan 16 '20 12:01 rvrangel

Is there any update to this Open PR?

wickeat avatar Sep 25 '23 08:09 wickeat