s3transfer
s3transfer copied to clipboard
added Tagging and TaggingDirective to ALLOWED_UPLOAD_ARGS
Related to Issue #94 and PR #96
Looks like that PR hasn't been updated in more than a year, so I am creating a new one to add Tagging and TaggingDirective to S3Transfer and also including the change on __init__.py.
Please pull the MR, I have been waiting 16 days now ^^ :)
I approve of this. Please make it happen asap. I don't want to upload an object and THEN add a tag..
+1
Any update on this? Would love to see this get merged
@rvrangel Thanks for the pull request and sorry about the delay here! I looked over the PR and it looked good. There was an edge case that needed to be added related to filtering out TaggingDirective from multipart copies. So I pulled in your commit, rebased it with the latest commits on develop, and fixed that edge case in this PR: https://github.com/boto/s3transfer/pull/155. This PR should be reviewed and merged shortly.
Thanks @kyleknap, really appreciate it 🙇
Is there any update to this Open PR?