botocore icon indicating copy to clipboard operation
botocore copied to clipboard

Typo in BOTOCORE_DEFAUT_SESSION_VARIABLES variable name

Open adamantoise opened this issue 4 years ago • 6 comments

Describe the bug In botocore/configprovider.py, the variable name BOTOCORE_DEFAUT_SESSION_VARIABLES contains a typo: the word DEFAUT should be spelled DEFAULT.

adamantoise avatar Apr 22 '21 21:04 adamantoise

Hi @adamantoise,

Thanks for the heads-up!

stobrien89 avatar Apr 22 '21 22:04 stobrien89

Hi @adamantoise,

Thanks for reaching out! We're aware of the typo in the variable, but unfortunately, fixing it isn't straight forward. Due to the age of the variable, it's difficult to know what downstream systems may be relying on this particular spelling. Any update would be a breaking change. We could rename the variable and create an alias for the old spelling, but this means users will still get incorrect suggestions in their IDE prompts etc.

For that reason, we haven't really touched it because the options available don't provide a lot of value. That's the conclusion we reached last time this was discussed at least, but please let us know if you have further thoughts.

nateprewitt avatar Apr 22 '21 23:04 nateprewitt

No problem if you want to close this as WONTFIX, it's obviously very minor and inconsequential. It's certainly not worth putting in a lot of effort to fix. (You could optionally add a comment explaining the unfortunate name if you'd like.)

adamantoise avatar Apr 22 '21 23:04 adamantoise

Yeah, I think a brief comment callout is a reasonable suggestion. We'll leave this open to track that as a quick follow up item. Thanks again for reviving the conversation.

nateprewitt avatar Apr 22 '21 23:04 nateprewitt

Greetings! It looks like this issue hasn’t been active in longer than one year. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one.

github-actions[bot] avatar Apr 26 '22 17:04 github-actions[bot]

This issue is still present (but, again, of little consequence). I'd prefer it though if a human closed this rather than a bot, if the decision is not to fix it.

adamantoise avatar Apr 26 '22 17:04 adamantoise

This was resolved in #3029, we should be set to close this now.

nateprewitt avatar Dec 12 '23 23:12 nateprewitt

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

github-actions[bot] avatar Dec 12 '23 23:12 github-actions[bot]