botocore icon indicating copy to clipboard operation
botocore copied to clipboard

Feature/overriding refresh token timeouts

Open rp4fx12 opened this issue 5 years ago • 1 comments

There might be a better approach here (or this may not be desired or needed at all) but this should allow for users to override the advisory and mandatory refresh timeouts that are a part of the RefreshableToken Class - addresses this issue: #2189

rp4fx12 avatar Oct 21 '20 03:10 rp4fx12

Codecov Report

Merging #2190 into develop will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2190      +/-   ##
===========================================
- Coverage    98.19%   98.18%   -0.01%     
===========================================
  Files           58       58              
  Lines        10843    10843              
===========================================
- Hits         10647    10646       -1     
- Misses         196      197       +1     
Impacted Files Coverage Δ
botocore/credentials.py 98.54% <100.00%> (-0.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c6205e5...842d2ac. Read the comment docs.

codecov-io avatar Oct 21 '20 03:10 codecov-io

Thank you for submitting this PR. After team discussion, we're going to have to discuss with other SDKs for potential cross-SDK approach to keep it consistent and decided not to consider this one at this time.

aBurmeseDev avatar Sep 12 '23 23:09 aBurmeseDev