botocore icon indicating copy to clipboard operation
botocore copied to clipboard

Normalize credentials log messages text and log level

Open ggarnier opened this issue 5 years ago • 3 comments

Change all "Found credentials" log messages level to debug, and also normalize similar messages to the same pattern.

This fixes #1841

ggarnier avatar Oct 02 '20 18:10 ggarnier

Codecov Report

Merging #2172 into develop will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2172   +/-   ##
========================================
  Coverage    98.21%   98.21%           
========================================
  Files           58       58           
  Lines        10806    10806           
========================================
  Hits         10613    10613           
  Misses         193      193           
Impacted Files Coverage Δ
botocore/credentials.py 98.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00a8324...ee4d7f1. Read the comment docs.

codecov-commenter avatar Oct 02 '20 18:10 codecov-commenter

Would love to have this merged in since I'm also affected by this. @kdaily since you are assigned to the issue, would you mind reviewing this and merging if it is good?

mvpatel2000 avatar Oct 04 '22 17:10 mvpatel2000

Thanks, this would be lovely! I was looking to do the same myself, then I started reading the CONTRIBUTING.rst and at the step "Check to see if there's an existing issue/pull request for the bug/feature.", I've found it :grin:

lancerinf avatar Oct 11 '22 19:10 lancerinf

Hi @ggarnier, thanks for this PR and for your patience on hearing back. After discussing this with the team, this is not something we're prioritizing currently, and we'll be closing the PR. Please let me know if you have any follow-up questions.

RyanFitzSimmonsAK avatar Sep 26 '23 21:09 RyanFitzSimmonsAK

@RyanFitzSimmonsAK I don't understand why you'd have to discuss prioritizing this. It's a very simple, no-breaking change.

ggarnier avatar Sep 27 '23 17:09 ggarnier

Hi @ggarnier, thanks for this PR and for your patience on hearing back. After discussing this with the team, this is not something we're prioritizing currently, and we'll be closing the PR. Please let me know if you have any follow-up questions.

This is a bug that the community is interested in fixing for you, please reconsider "prioritizing" it.

lancerinf avatar Sep 27 '23 22:09 lancerinf

Hi @ggarnier, thanks for this PR and for your patience on hearing back. After discussing this with the team, this is not something we're prioritizing currently, and we'll be closing the PR. Please let me know if you have any follow-up questions.

The PR is already done, so I am not sure what needs to be prioritized. It is a very annoying bug, and it would be very valuable if someone approved the PR. It's 5 lines and can be reviewed in 30 seconds.

mvpatel2000 avatar Sep 28 '23 00:09 mvpatel2000