botocore icon indicating copy to clipboard operation
botocore copied to clipboard

Add SOCKS proxy support

Open dbevacqua opened this issue 4 years ago • 4 comments

Although this "works for me", it's still work in progress and needs at least some more tests in test_http_session.py to cover cases where URLLib3Session is configured with SOCKS proxies. Before going any further I wanted to verify the general approach.

One particular question is how to avoid warnings from importing urlib3.contrib.socks when socks (an optional dependency) is not available.

dbevacqua avatar Jun 18 '20 15:06 dbevacqua

Codecov Report

Merging #2081 into develop will decrease coverage by 0.08%. The diff coverage is 73.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2081      +/-   ##
===========================================
- Coverage    93.11%   93.03%   -0.09%     
===========================================
  Files           60       60              
  Lines        11096    11136      +40     
===========================================
+ Hits         10332    10360      +28     
- Misses         764      776      +12     
Impacted Files Coverage Δ
botocore/awsrequest.py 95.31% <36.36%> (-2.26%) :arrow_down:
botocore/httpsession.py 91.08% <85.71%> (-1.40%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b195fc0...1e0c731. Read the comment docs.

codecov-commenter avatar Jun 18 '20 15:06 codecov-commenter

I have a need to access AWS endpoints over SOCKS5 proxy and I've tested this modification successfully in that environment. Are you still working on this PR, and is there anything I could help with?

hnousiainen avatar Apr 14 '21 07:04 hnousiainen

@dbevacqua

Are you still working on this feature? Would you mind if I pick it up?

zhan9san avatar Oct 20 '21 02:10 zhan9san

@zhan9san please be my guest

dbevacqua avatar Oct 20 '21 08:10 dbevacqua

Thank you for creating this PR. After bringing this up for discussion with the team we decided to continue tracking this request in https://github.com/boto/botocore/pull/2541 going forward, with the latest update here: https://github.com/boto/botocore/pull/2541#issuecomment-1666001438

tim-finnigan avatar Sep 13 '23 17:09 tim-finnigan