botocore
botocore copied to clipboard
Add SOCKS proxy support
Although this "works for me", it's still work in progress and needs at least some more tests in test_http_session.py
to cover cases where URLLib3Session
is configured with SOCKS proxies. Before going any further I wanted to verify the general approach.
One particular question is how to avoid warnings from importing urlib3.contrib.socks
when socks
(an optional dependency) is not available.
Codecov Report
Merging #2081 into develop will decrease coverage by
0.08%
. The diff coverage is73.91%
.
@@ Coverage Diff @@
## develop #2081 +/- ##
===========================================
- Coverage 93.11% 93.03% -0.09%
===========================================
Files 60 60
Lines 11096 11136 +40
===========================================
+ Hits 10332 10360 +28
- Misses 764 776 +12
Impacted Files | Coverage Δ | |
---|---|---|
botocore/awsrequest.py | 95.31% <36.36%> (-2.26%) |
:arrow_down: |
botocore/httpsession.py | 91.08% <85.71%> (-1.40%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b195fc0...1e0c731. Read the comment docs.
I have a need to access AWS endpoints over SOCKS5 proxy and I've tested this modification successfully in that environment. Are you still working on this PR, and is there anything I could help with?
@dbevacqua
Are you still working on this feature? Would you mind if I pick it up?
@zhan9san please be my guest
Thank you for creating this PR. After bringing this up for discussion with the team we decided to continue tracking this request in https://github.com/boto/botocore/pull/2541 going forward, with the latest update here: https://github.com/boto/botocore/pull/2541#issuecomment-1666001438