botocore
botocore copied to clipboard
s3: Decode Prefix query param reflected back in response
Otherwise you get inconsistent decoding when working with non-ASCII keys:
>>> c.list_objects(Bucket='1space-test', Prefix='my\N{SNOWMAN}', Delimiter='\N{SNOWMAN}', Marker='a\N{SNOWMAN}')
{'Contents': ...,
'Delimiter': '☃',
'EncodingType': 'url',
'IsTruncated': False,
'Marker': 'a☃',
'MaxKeys': 1000,
'Name': '1space-test',
'Prefix': 'my%E2%98%83',
'ResponseMetadata': ... }
Codecov Report
Merging #1901 into develop will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #1901 +/- ##
========================================
Coverage 92.62% 92.62%
========================================
Files 53 53
Lines 10035 10035
========================================
Hits 9295 9295
Misses 740 740
Impacted Files | Coverage Δ | |
---|---|---|
botocore/handlers.py | 96.92% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update be2bd7e...a73d9c2. Read the comment docs.
Anything else I should do to help move this forward?
It's been a couple years now... Anything I can do to help move this forward?
Hi @tipabu thanks for your patience. I wanted to check in here as we are going through old PRs and this one appears to have fallen off of the radar. I brought this up for discussion with the team, and the consensus was that more information is needed here before moving forward.
If this is still a problem that needs addressing, can you create a corresponding issue for tracking? We would like to gather more info on the use cases for this, whether there are workarounds, and possible approaches for addressing the issue.
Closing as we have not heard back regarding the previous comment. The team can revisit this PR if necessary but as mentioned above, more information is needed and should be provided in a tracking issue for further discussion.