botocore
botocore copied to clipboard
Support for mfa_serial in shared credentials
Trying to address the issue I have created in aws-cli project https://github.com/aws/aws-cli/issues/3172
I would like to support MFA for standard access keys (which does not require assumerole).
Curious, any objections for implementing it this way? If not I will add tests to finish work on this PR.
After this PR I will also open similar to AssumeRole in aws-cli to support JSONFileCache.
Codecov Report
Merging #1399 into develop will increase coverage by
0.01%
. The diff coverage is94%
.
@@ Coverage Diff @@
## develop aws/aws-cli#1399 +/- ##
===========================================
+ Coverage 80.52% 80.53% +0.01%
===========================================
Files 87 87
Lines 12123 12145 +22
===========================================
+ Hits 9762 9781 +19
- Misses 2361 2364 +3
Impacted Files | Coverage Δ | |
---|---|---|
botocore/credentials.py | 98.06% <94%> (-0.35%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e6791f2...9fb891f. Read the comment docs.
cc @JordonPhillips
related change in aws-cli
https://github.com/aws/aws-cli/pull/3174
Can this get another review? It would be really great to support this by now.
Hi... any news on this? I also am in need of this feature..
Thanks,
Considering how long this has been dead, has the usability issue been addressed by something else somewhere else?
@hovissimo the easies way to solve this issue - switch to assumerole option.
@nateprewitt @atomicfruitcake @wimglenn @zdutta
Can this please get assigned to someone?
How can we (cloud users) be expected to improve our security stance when the cloud provider doesn't provide us with the tools. Please review and commit this.
Nothing to comment other then, this is more than 5 years old and there is support for this feature.
When will this be implemented?
For everyone watching this issue, please send a link of this thread to your assigned solutions architect. AWS won't care about this unless they hear about it A TON through their internal support channels.
If you are commenting here anymore, it's a waste of time. Open a support ticket. Spam them.
Hi all, thanks for your patience here and apologies that it has taken so long to get a response. I have transferred the related issue (https://github.com/aws/aws-sdk/issues/529) to our cross-SDK repository for further tracking. As mentioned in that issue, a design proposal is required in order to consider how the implementation would work across SDKs. Changes involving shared credentials generally need to be considered at a cross-SDK level in order to maintain consistency. Please 👍 the issue if interested in this feature and comment if you have any additional information to share.