boto3 icon indicating copy to clipboard operation
boto3 copied to clipboard

on_done not called when token has expired

Open daveisfera opened this issue 9 months ago • 14 comments

Describe the bug

If the token has expired, then the file isn't uploaded (expected), but on_done is not called and there's no way to get notification of the failure

(refiling https://github.com/boto/s3transfer/issues/304 here since I use s3transfer through boto3)

Expected Behavior

An error would be reported

Current Behavior

The upload silently fails

Reproduction Steps

  1. Create a token using aws-vault
  2. Do an upload
  3. Verify success
  4. Wait for token to expire
  5. Do an upload
  6. Notice that no error is reported and on_done is never called

Possible Solution

Report an error using on_done in the same way from before the expiration

Additional Information/Context

No response

SDK version used

1.34.97

Environment details (OS name and version, etc.)

Debian Bookworm with Python 3.12.3

daveisfera avatar May 23 '24 20:05 daveisfera