boto icon indicating copy to clipboard operation
boto copied to clipboard

Support for AWS_CONTAINER_CREDENTIALS_RELATIVE_URI variables (Docker)

Open lafraia opened this issue 8 years ago • 12 comments

With the release of IAM Roles for Tasks a new environment variable is provided inside containers. It shouldn't be hard to add this support.

curl 169.254.170.2$AWS_CONTAINER_CREDENTIALS_RELATIVE_URI 

The command above returns temporary credentials.

lafraia avatar Jul 21 '16 02:07 lafraia

Can we get either #3804 or #3810 merged to resolve this issue?

joshma avatar Sep 10 '18 01:09 joshma

@joshma development seems to have stopped on boto, with just one release in the last year: https://pypi.org/project/boto/#history . I suspect this will never get fixed in boto. boto3 supports these credentials, can you upgrade to that?

adamchainz avatar Sep 10 '18 09:09 adamchainz

@adamchainz All of our new code uses boto3, but there'll always be legacy code. :)

But that's fair, I was hoping we'd make some sort of exception. (My argument would be that this breaks existing code when we moved to containers, unlike most other improvements.)

joshma avatar Sep 10 '18 20:09 joshma

You can probably patchy.patch in the fix from #3810 if you're desperate

adamchainz avatar Sep 10 '18 22:09 adamchainz

Sorry, I wasn't clear in my original request: https://github.com/boto/boto/pull/3804 is actually someone from our team (hi @raylu), and we're using that fork (installing from git like @tedder suggested): https://github.com/benchling/boto/commit/9b4c489fed6c37b40285d2717f487d01e4402807

However, it'd be nice if one of the fixes were "blessed" and merged into boto, so that it's one less thing for our team to maintain and we get some assurance that we did the right thing.

At the end of the day, it's not a big deal, and I get that it's extra work I'm asking of the maintainers here. We'll probably keep using our fork, but I thought I'd check to see if folks were open to doing another release.

joshma avatar Sep 11 '18 02:09 joshma

Is there any movement on this ?

50nar avatar Jan 26 '19 14:01 50nar

any ideas/ workarounds?

agalazis avatar Sep 29 '19 23:09 agalazis

https://github.com/boto/boto3/issues/1428 based on this it already does so?

agalazis avatar Oct 01 '19 14:10 agalazis

that's boto3. this is a different project

raylu avatar Oct 01 '19 18:10 raylu

the comment mentions boto core

agalazis avatar Oct 03 '19 04:10 agalazis

but makes sense since this project might not be using it or its latest version

agalazis avatar Oct 03 '19 04:10 agalazis