yagpdb icon indicating copy to clipboard operation
yagpdb copied to clipboard

Typo fixes, active reading, update to a message

Open iirccm opened this issue 3 years ago • 4 comments

Hello, I know this change might seem trivial but it's my first contribution into someone else's project on this platform so please let me know if I had an obvious mistake or a missing part mainly about the general rules (e.g. wrong use of a specific area, wrong terminology, breaking some guidelines etc.)

Note: I use Squash and merge option for these kind of basic stuff to maintain a cleaner committing history so I feel like I can keep track of more important parts. Is there a similar approach like this or I'm doing something wrong?

Question-1: I remember I added two labels for a better classification but it seems they are not shown here. Why don't we have the permission to do this as contributors?

20210311_231837_PullRequestQuestion

Question-2: About the picture above, how do I see someone else's commit into my own pull request even before I opened it? I don't understand the system of it. How is this possible? Also keep in mind that, jonas747's commit seems to be done into a different branch from mine which was added about a month ago. Can someone explain me what's going on about this?

iirccm avatar Mar 11 '21 00:03 iirccm

The documentation is not complete, there are still many things that need to be documented as well as the ongoing German translation which is being written by one person.

@NaruDevnote Is there a way to contribute to the documentation? So we can add the related link into the place to inform people if they want to help. Otherwise, I'm not sure how to change the sentence since it still indicates the documentation might not be complete.

Edit: typo

iirccm avatar Mar 20 '21 15:03 iirccm

@NaruDevnote Is there a way to contribute to the documentation? So we can add the related link into the place to inform people if they want to help. Otherwise, I'm not sure how to change the sentence since it still indicates the documentation might not be complete.

To contribute to the German translation, speak to LZeuch#7325 in the YAGPDB Support Server. The official documentation is managed by the server staff only (documentation authors, voluntary support, and admins) so the only way to "contribute" is by suggesting changes / speaking to an author directly.

In the meantime, best to leave it as it is, the documentation will not be complete any time soon as far as I know. :)

devnote-dev avatar Mar 22 '21 15:03 devnote-dev

I see, I have just reverted the related sentence as you noted but I also added a little message for people if they want to contribute in any ways. By this way, they would know if the project is open to help & suggestions and maybe some of them come and ask how they can help about it.

iirccm avatar Mar 23 '21 14:03 iirccm

Please rebase this to Master.

ashishjh-bst avatar Apr 26 '22 08:04 ashishjh-bst