py-business-calendar
py-business-calendar copied to clipboard
botant
fix Calendar.busdaycount() crash when date1 is a last known holiday (#4)
not sure why it fails.. I saw the same issue with tests when trying to launch them locally, even without my changes
Hi @stebunovd, apologies for not responding sooner. There seems to be a lot of features/fixes in this diff. Would you be able to submit just the bug fix in a different PR? Thanks!
Hi @botant, nice to meet you :) It's a cool library, thank you for creating it! Since it was unmaintained for too long, we had to switch to our fork at https://github.com/ivelum/py-business-calendar and it's currently used in our teamplify.com project.
What are your plans for py-business-calendar? Of course, if it will be maintained again and the fixes and features that we've added could be merged into the upstream, we'll happily switch from our fork to the official distribution.
I'm updating the project now with pyproject.toml, tox, pytest, pre-commit, black, flake8, etc. CI seems to be broken as well. Or rather everything is broken at the moment. Once I get everything up and running, including the fix you posted above, I'll let you know and then we can look at suggestions, improvements, etc. Cheers!
@stebunovd it is working now, but I still need to fix the CI, and probably add a few more tests around warnings and date conversion. I also want to add typing hints and export a typing stub that can be used with mypy. On top of that, the landscape has changed considerably since I wrote this, so I need to update the Docs as well. Either way, version 1.0.0 should be ready soon.
If you could take a look at the new branch and tell me if anything there doesn't work for you, it would be great. Thanks.
Getting there. Last failure in Travis is now related to Python 2.7. Not sure I need to keep supporting it. You're not on Python 2.7 by any chance are you?
thanks @botant, these are good news. We're using Python 3.8. Me and my colleagues will be watching the project