agora icon indicating copy to clipboard operation
agora copied to clipboard

BanManager only bans client connection, not server

Open Geod24 opened this issue 3 years ago • 0 comments

The BanManager only bans nodes that it tries to connect to, based on failed request.

https://github.com/bosagora/agora/blob/bcd14f2c6a3616d7f05ef850dc95fae3eb386760/source/agora/network/Client.d#L561-L562

While it will be used to ban incoming connections too (not in tests tho), it only do so based on outgoing requests:

https://github.com/bosagora/agora/blob/226186535c02a31d2f5ca30522897470c58f8d1f/source/agora/node/Runner.d#L103-L104

Geod24 avatar Mar 30 '21 01:03 Geod24