llvm icon indicating copy to clipboard operation
llvm copied to clipboard

replace mtl by transformers

Open amigalemming opened this issue 11 years ago • 7 comments

After our last discussion in the mailing list I have replaced mtl by transformers in llvm-tf. I propose to do the same replacement in 'llvm', too. I have prepared a commit for this purpose, that you may simply pull in: http://code.haskell.org/~thielema/llvm-pull/transformers/

'transformers' does not need any language extensions and does not export identifiers from Control.Monad and other 'base' modules.

amigalemming avatar May 22 '13 08:05 amigalemming

Can you fix llvm-base as well? It doesn't make much sense to remove it from one location but not the other.

NathanHowell avatar May 22 '13 14:05 NathanHowell

LLVM.ST is now ported to transformers, as well.

amigalemming avatar May 22 '13 17:05 amigalemming

@amigalemming can you please give us a pull request so we can review the code changes etc?

thanks

cartazio avatar May 22 '13 17:05 cartazio

The commit is here: http://code.haskell.org/~thielema/llvm-pull/transformers/ What else do you need?

I found the pull-requests via github very cumbersome (mix of shell and web access, looping javascripts at github, impossibility to remove commits), thus I am using code.haskell.org.

amigalemming avatar May 22 '13 17:05 amigalemming

do you want us to look at the patch or not? If yes, please take the 5 minutes to do a pull request.

look forward to seeing the pull request.

cartazio avatar May 22 '13 18:05 cartazio

Is there a way to fork, making pull requests etc. via command line instead of the broken web interface?

amigalemming avatar May 22 '13 18:05 amigalemming

a cursory google search indicates http://stackoverflow.com/questions/4610530/github-cli-clients which in turn links to a bunch.

cartazio avatar May 22 '13 19:05 cartazio