borzari

> > Old DQM compare modules for pixel rechits, tracks and vertices were removed. > > does this still apply? No, I just removed it. Thanks!

> > Old DQM compare modules for pixel rechits, tracks and vertices were removed. > > overall I am confused by amount of comparison we need to support. Could someone...

> Please clarify: you are updating offline relval workflows, so none of this needs to run during data taking at P5? Or is there a (small?) set of changes required...

Hi @slava77 I applied what you suggested in [this commit](https://github.com/cms-sw/cmssw/compare/master...borzari:cmssw:rmTryCatch), used the opportunity to remove some duplicated code, and tested it with RelValZMM and RelValTTbar events by comparing the version...

> > Tracks are apparently not pure generalTracks, see https://github.com/cms-sw/cmssw/blob/dbbd44f6792e61b79f46b7f9974eec7cf8e3024b/RecoTracker/FinalTrackSelectors/plugins/SingleLongTrackProducer.cc#L133-L136 > > > > a proper copy is made conditionally, while the rest in `selTracks` is going to be default-constructed...

> @borzari > > > also want to check if the rechits and hits from the hitpattern are valid to say that it is a goodTrack that can be used...

> > I also want it to have `recHitsOk()`, right? > > Right, this is what I had in mind. It didn't work. If I move the validity check from...

> Isn't `track.recHitsOk()` checking that the `TrackExtra` is valid? Should be. I implemented it like Slava suggested [here](https://github.com/borzari/cmssw/blob/95ecc4bb4aa7e811f1f65025c8f08a23a72cf272/DataFormats/TrackReco/interface/Track.h#L160-L161) Could it be that, although I am adding only tracks with valid...

> The check I used was > > ``` > if (track.extra().isAvailable()) { > ``` Alright @Dr15Jones, but does it happens every time I am using a `reco::Track` anywhere? Well,...

@mmusich most probably I was missing something. The main differences I see (besides the better organization of the code in the way you wrote), is that I included `track.recHitsOk()` [here](https://github.com/CMSTrackingPOG/cmssw/commit/53185493eae82d7fe8e807e9b266491ea51d06f8#diff-00675fb147733049a7c1d96cd8ae48cffba247a0b216d37b99f3f87ecd034044R117)...