bors-servo

Results 436 comments of bors-servo

:umbrella: The latest upstream changes (presumably #443) made this pull request unmergeable. Please resolve the merge conflicts.

**Comment by [kornelski](https://github.com/kornelski)** _Thursday Sep 14, 2017 at 19:10 GMT_ ---- +1 I wanted to add some methods, but complete lack of any documentation is very discouraging. How to handle...

:umbrella: The latest upstream changes (presumably #485) made this pull request unmergeable. Please resolve the merge conflicts.

**Comment by [jdm](https://github.com/jdm)** _Sunday Feb 05, 2017 at 15:36 GMT_ ---- I wonder if we should make eventType() return an Option to avoid any similar cases.

**Comment by [iszak](https://github.com/iszak)** _Friday Aug 18, 2017 at 23:33 GMT_ ---- @mitchmindtree In case you never found what the missing event types, they should be the following - 0 NullEvent...

**Comment by [mitchmindtree](https://github.com/mitchmindtree)** _Saturday Aug 19, 2017 at 14:18 GMT_ ---- @iszak nice! Do you have any references for these events? Or did you just find them by experimenting?

**Comment by [iszak](https://github.com/iszak)** _Saturday Aug 19, 2017 at 14:51 GMT_ ---- @mitchmindtree I found them by disassembling AppKit, my assembly is not great so there is a chance these are...

**Comment by [viraptor](https://github.com/viraptor)** _Sunday Mar 05, 2017 at 04:16 GMT_ ---- For more info, confirming on rust 1.15.1 and libs: ``` Compiling core-foundation-sys v0.3.1 Compiling objc v0.2.2 Compiling core-foundation v0.3.0...

**Comment by [savruk](https://github.com/savruk)** _Tuesday May 16, 2017 at 21:45 GMT_ ---- This on the other hand compiles(rustc 1.17.0, cocoa = "0.8.1"): ```rust extern crate cocoa; use cocoa::appkit::{NSStatusBar, NSApp}; use cocoa::base::nil;...

**Comment by [frewsxcv](https://github.com/frewsxcv)** _Sunday Jun 18, 2017 at 20:18 GMT_ ---- Yep, initializing the app first seems to be required. Ideally, there'd be a better error for this scenario, but...