Michiel Borkent comments

Results 1117 comments of


                                            Michiel Borkent

Keyword argument fns don't accept map arguments

The full commit that made it work for SCI on Clojure 1.11: https://github.com/babashka/sci/commit/b6ab05d5e4b0d6df594a6e03a5849caf82caecb3

Commands to bump or set version patch | minor | major

We should probably also support setting the patch version to a user-supplied value: ``` neil version patch $(git commit-count) ```

Commands to bump or set version patch | minor | major

Sweet!

Commands to bump or set version patch | minor | major

Good point. I'm ok with breaking the current `neil version`.

Commands to bump or set version patch | minor | major

I've personally moved away from git-count-based versioning for a few reasons: 1. I find commit count not really useful information (vs just the release count). 2. It complicates releases, in...

Commands to bump or set version patch | minor | major

Repeating from the original post: > I think it makes sense to store the version numbers separately: {:major ".." :minor ".." :patch ".." :qualifier ".."} similar to how *clojure-version* is...

Commands to bump or set version patch | minor | major

The idea here is to store the latest released version in the `deps.edn`: that is the source of truth, like in `project.clj`: not some string or expression that still needs...

Commands to bump or set version patch | minor | major

OK, let's do it

Commands to bump or set version patch | minor | major

I wonder if we should store the version attributes as strings (since perhaps people will use different things) or even as a single string, as this allows people to be...

Commands to bump or set version patch | minor | major

Storing the version as a single string has the benefit that you don't need any other libraries to pull it out and use it e.g. in `build.clj`. Storing the single...