react-sparklines icon indicating copy to clipboard operation
react-sparklines copied to clipboard

1.7.0 has circles on every point

Open Haroenv opened this issue 7 years ago • 4 comments

This is not visible on the demo, but maybe that's not been updated.

1.6.0 1.7.0
screen shot 2017-08-02 at 16 35 06 screen shot 2017-08-02 at 16 34 43
https://codesandbox.io/s/5z0xJlnK https://codesandbox.io/s/rRw5W9OqE
import React from 'react';
import { Sparklines, SparklinesLine } from 'react-sparklines';

const ActivityGraph = () => (
  <Sparklines
    data={[0, 2, 0, 5, 2, 0, 4, 1, 1, 1, 4, 3, 0]}
    width={100}
    height={15}
  >
    <SparklinesLine color="#2C8EBB" />
  </Sparklines>
)

Haroenv avatar Aug 02 '17 14:08 Haroenv

I'm having the same problem. I thought that is what SparklinesLineSpots is for. All my parks are now showing unwanted spots and not sure how to remove them. Will have to downgrade to 1.6.

Gervwyk avatar Aug 04 '17 09:08 Gervwyk

I'm having this issue too. The tooltip circles were introduced here: https://github.com/borisyankov/react-sparklines/commit/f1dbc9ea65b7a6c5653da997328ddc2b31e10850#diff-9781cfc177343ee1017e63e5e715f2eb Shouldn't they only be visible on hover? The tooltip circles could also be made optionally with a new prop e.g. disableTooltips. I can open a pull request for the latter if desired.

cbergmiller avatar Oct 25 '17 11:10 cbergmiller

Quick temporary solution with the CSS:

svg circle{
  display: none;
}

banzy avatar Jul 01 '18 09:07 banzy

Quick temporary solution with the CSS:

svg circle{
  display: none;
}

The problem is that this generates a lot of unnecessary code.

dejurin avatar Sep 09 '22 17:09 dejurin