react-sparklines Sparkline SVG should be responsive

As I understand it, by omitting the height and width attributes on the svg element it will cause the spark line to fill the parent container. This is the behavior I hoped for.

I envision the default settings to only apply a height and width to the viewbox. And expose two new properties on the component: svgHeight and svgWidth

Additionally, I think it would be great to expose preserveAspectRatio with a default value of 'none'.

If you agree with this direction I'll happily submit a pull request

Apr 14 '16 02:04 codecounselor

I agree with the decision, I was thinking about this as well. Will happily accept a PR.

Apr 14 '16 12:04 borisyankov

PR is done, but Travis is failing for some reason

Apr 14 '16 15:04 codecounselor

@motiz88 commented on the pull request. Not sure if we're in alignment now or not. But it looks like his previous pull request for TravisCI is a prerequisite for this one. @borisyankov, what do you think?

Apr 15 '16 13:04 codecounselor