react-sparklines
react-sparklines copied to clipboard
Support gaps in data (null, NaN, etc)
I'm submitting this PR to gauge interest in the completed feature and get some feedback before I go ahead and implement it all.
The idea is to graphically represent data with in-band null
s, NaN
s or infinite values by drawing the valid (finite numeric) segments separately from one another.
That is a really good idea. :+1:
Whew! OK, I think this thing is quite complete. Any thoughts?
As for me, I still wonder about the gaps
prop. Right now it's not treated very consistently in the code and I'm thinking about removing it entirely. So the equivalent of gaps={true}
would be the default and only behavior. I'd appreciate your opinion here.
I agree, this being the default options, sounds like a good idea.
I implemented this and one existing test was broken - this one. I'll rebase this on master in a minute, so we can use Travis here again.
It's your call, @borisyankov. As a user, I'm comfortable with this change, but I'm just one data point. Having this on by default should probably be semver-major to avoid breaking others' code.
@borisyankov Any thoughts on getting this merged? I could use it :)
@motiz88 any interest in getting this current with master
? I am trying to pull this my branch but am late to the party and unsure of status. Thanks.
@motiz88 Has been a while. I am committed to merging it into master.