react-sparklines icon indicating copy to clipboard operation
react-sparklines copied to clipboard

Support gaps in data (null, NaN, etc)

Open motiz88 opened this issue 8 years ago • 7 comments

I'm submitting this PR to gauge interest in the completed feature and get some feedback before I go ahead and implement it all. The idea is to graphically represent data with in-band nulls, NaNs or infinite values by drawing the valid (finite numeric) segments separately from one another.

motiz88 avatar Apr 12 '16 15:04 motiz88

That is a really good idea. :+1:

borisyankov avatar Apr 12 '16 16:04 borisyankov

Whew! OK, I think this thing is quite complete. Any thoughts?

As for me, I still wonder about the gaps prop. Right now it's not treated very consistently in the code and I'm thinking about removing it entirely. So the equivalent of gaps={true} would be the default and only behavior. I'd appreciate your opinion here.

motiz88 avatar Apr 13 '16 18:04 motiz88

I agree, this being the default options, sounds like a good idea.

borisyankov avatar Apr 14 '16 13:04 borisyankov

I implemented this and one existing test was broken - this one. I'll rebase this on master in a minute, so we can use Travis here again.

It's your call, @borisyankov. As a user, I'm comfortable with this change, but I'm just one data point. Having this on by default should probably be semver-major to avoid breaking others' code.

motiz88 avatar Apr 14 '16 14:04 motiz88

@borisyankov Any thoughts on getting this merged? I could use it :)

jarib avatar Sep 03 '16 14:09 jarib

@motiz88 any interest in getting this current with master? I am trying to pull this my branch but am late to the party and unsure of status. Thanks.

timelyportfolio avatar Nov 04 '16 15:11 timelyportfolio

@motiz88 Has been a while. I am committed to merging it into master.

borisyankov avatar Jan 20 '17 02:01 borisyankov