react-sparklines icon indicating copy to clipboard operation
react-sparklines copied to clipboard

Added SparklinesInteractiveLayer

Open vegetableman opened this issue 7 years ago • 3 comments

Made it a little interactive

interactive

vegetableman avatar Sep 01 '18 05:09 vegetableman

@borisyankov are we going to have this similar interactive layer at some point?

arslanhashmi avatar Jul 11 '20 23:07 arslanhashmi

Great PR! Just what I was looking for.

Question. Did you need an updated version of react and react-dom for this?

If not, it's probably making the scope for this PR bigger than it should

qcho avatar Sep 03 '21 12:09 qcho

It's been 3 years... time sure passes.

Anyways, @qcho had to check my code again. On the issue, I updated react because I was using React.Fragment which is not supported in react 15.

Have updated the PR now and I have removed fragment, reverted the versions back to old one and now am using the svg g tag which works equally well.

Cheers!

vegetableman avatar Sep 05 '21 14:09 vegetableman