gtsfm icon indicating copy to clipboard operation
gtsfm copied to clipboard

Fix two failing unit tests w.r.t. MVS utilities

Open johnwlambert opened this issue 3 years ago • 0 comments

Two tests are failing currently: TestEllipsoidUtils.test_get_right_singular_vectors and TestPatchmatchNetData.test_select_src_views.

The first is due to the fact that we aren't returning singular values, so we need to correct the terminology. The other test looks like it is flaky due to some random ordering of the output.

>       assert np.allclose(singular_values, S)
E       AssertionError: assert False
E        +  where False = <function allclose at 0x7fefe2b41f70>(array([7.73928148, 2.82711821, 1.20177289]), array([13.40482874,  4.89671238,  2.08153171]))

johnwlambert avatar Dec 22 '21 04:12 johnwlambert