vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Vorta passes only --filter=AM flag and doesn't allow overriding or editing this flag

Open justauserid opened this issue 3 months ago • 9 comments

Description

As seen below (from logs), Vorta already calls bog breate with --filter=AM

INFO - Running command /opt/homebrew/bin/borg create --list --progress --info --log-json --json --filter=AM -C zstd,8 …

But if I want to rather use --filter=AME then it is not possible to override this option, because Vorta then just repeats the flag

… --log-json --json --filter=AM -C zstd,8 --verbose --filter=E --show-rc ..

which reults in error (and shows up in the log below).

Steps to reproduce the behavior:

  1. Go Schedule tab > >_ Shell Commands > Extra argumetns for borg create
  2. pass --filter=AME or --filter=E
  3. Try Start backup
  4. Observe backup failing because the flag gets added twice, does not get overridden.

Environment

  • OS: macOS Sequoia 15.6.1
  • Vorta version: 0.10.3
  • Installed from: binary
  • Borg version: 1.4.1

Logs

2025-09-09 07:12:31,104 - vorta.borg.borg_job - INFO - Running command /opt/homebrew/bin/borg create --list --progress --info --log-json --json --filter=AM -C zstd,8 --verbose --show-rc --exclude-nodump --filter=AME --exclude-if-present CACHEDIR.TAG --exclude-from /var/folders/tp/zj0y3lcj18d6g ..... 

2025-09-09 07:12:31,309 - vorta.borg.borg_job - WARNING - usage: borg create [-h] [--critical] [--error] [--warning] [--info] [--debug]

....

2025-09-09 07:12:31,317 - vorta.borg.borg_job - WARNING - borg create: error: argument --filter: There can be only one.

Expected behaviour

  1. Flags should be allowed to be overriden by this Extra argumetns for borg create feature
  2. Or hardcoded/default flags should be allowed to be changed by some other means/feature

justauserid avatar Sep 09 '25 01:09 justauserid

Vorta defaults to --filter=AM - and adds the parameter automatically. Users should be able to override default command line parameters - if Vorta does not rely on them.

Workaround (e.g. for debugging): Copy and paste the borg command from the logs to a terminal - adapt and execute. Obviously, this workaround does not provide a solution for scheduled backups.

goebbe avatar Sep 21 '25 19:09 goebbe

Hi @goebbe, sorry I didn't understand. Are you infering from the issue and just typing it out here again for claring or so, or sharing a solution (for working around this issue "in Vorta")?

justauserid avatar Sep 23 '25 04:09 justauserid

Hi @goebbe, sorry I didn't understand. Are you infering from the issue and just typing it out here again for claring or so, or sharing a solution (for working around this issue "in Vorta")?

I just confirmed - and added a workaround. Also, I vaguely remember that this issue has been reported/discussed in the past. There may be "closed" issues that are related.

goebbe avatar Sep 24 '25 08:09 goebbe

I just confirmed -

Got it.

and added a workaround.

Not a workaround I'd say. Also, I have debugged it already and tested. As for running commands from the terminal, yes this is how this command (and filter) works, or if I have my own script via cron/etc.

The bug reprot is for Vorta app and at this point I do believe it's indeed a bug. IMHO Vorta ought run with the bare minimum or if it wants to icnlude a filter/flags then there should be ways to change modify them.

Also, I vaguely remember that this issue has been reported/discussed in the past. There may be "closed" issues that are related.

I had searched the issues before raising it and could not find this issue. I searched again. Please feel free to link if you find one. Though I wonder why that would be closed as the fix is not in the latest yet.

justauserid avatar Sep 26 '25 12:09 justauserid

Quite some Vorta issues are closed automatically, afters some weeks of inactivity. :-(

Actually, I was wrong about the existing issue: #1982 is about the fact that the logs do not display the expected output, even when the correct command line option is in the borg command. So even if this is vaguely related - it is still a different issue.

goebbe avatar Sep 26 '25 13:09 goebbe

Maybe I shall tag the maintainer then?

justauserid avatar Sep 28 '25 00:09 justauserid

Hi @m3nu, would you please consider this bug for a furure release? (Here was the discussion - there's no discussion there though https://github.com/borgbase/vorta/discussions/2274)

justauserid avatar Sep 29 '25 13:09 justauserid

I believe we have this flag to get the right details for status logs.

m3nu avatar Sep 29 '25 14:09 m3nu

I believe we have this flag to get the right details for status logs.

Yes, but Vorta doesn’t pass “E” or gives the user an option to append/overwrite it along with “AM”.

‘E’ = regular file, an error happened while accessing/reading this file

justauserid avatar Sep 29 '25 17:09 justauserid