Add a setting toggle to enable/disable system tray icon.

[CScallops]

The problem

This is tangentially related to #2204 . Some people have a system tray in their DE but would rather Vorta followed a more conventional approach, not using the system tray and closing the app when you close it, instead of minimizing to tray.

Requested Solution

A toggle switch on the settings dialog for "Use system tray". For systems without a system tray, that will be disabled and locked on "No". For all others, it would default to "Yes" but the user would have an option of switching it.

Alternatives

Just live with it, I guess.

Additional context

None.

[VandalByte]

This does sound like a great addition to me, giving users more control over the running application. We could perhaps add a checkbox for this with a label like Minimize to system tray when closing the window? under Vorta's Misc Settings.

If you'd like to open a PR for this, I'd be happy to see it through.

[CScallops]

Oof, I haven't touched Python in over 15 years. Let me see if I'm up to the challenge. At least there's https://github.com/borgbase/vorta/pull/2205 to give me a clue of where to look for things. Yeah, I think I can tackle this. I'll try and set up a development environment. If things go south I'll just post here and let someone else take it to the finish line.

[VandalByte]

Yeah, I think I can tackle this. I'll try and set up a development environment. If things go south I'll just post here and let someone else take it to the finish line.

Great! Yeah you can give it a try, otherwise someone else will pick up the PR later later on and implement the rest.

You can check out the settings.py, I believe this is where the new option needs to go. It seems to populate itself so you don't have to go into the UI design part. https://github.com/borgbase/vorta/blob/1acbc0b6c9ac0f4dfd7ef6a58066af4bd4b12ef9/src/vorta/store/settings.py#L24-L31

Then I believe you will have to implement the functionality of that setting in main_window.py.

Thanks

[VandalByte]

I also just noticed the option in the settings: "Show main window of Vorta on launch" which basically controls whether the main window appears or the app runs in the tray when launched.

With your addition, this option would become redundant, since the main window would be forced to appear if the tray is disabled. So you will need to try and make it work so that this option not affected by the new addition and is disabled if tray is not being used/unavailable.

This will probably need changes to existing test cases as well and require a lot of testing.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue was closed because it has been stalled for 7 days with no activity.