vorta icon indicating copy to clipboard operation
vorta copied to clipboard

validation and compaction interval not changeable

Open ThomasWaldmann opened this issue 1 year ago • 8 comments

Description

See picture:

  • the compaction interval is disabled, so one can not change the value of it. i did not touch anything there, so this is a bug: it should be changeable.
  • the validation interval is enabled, so one can change the value of it. this is because i toggled the checkmark to off and to on again to get it into that state. this is a workaround for this bug.
Screenshot 2024-10-18 at 19 45 12

Reproduction

  • [X] I tried to reproduce the issue.
  • [X] I was able to reproduce the issue.

OS

macOS 15

Version of Vorta

0.10.0 beta1

What did you install Vorta with?

Binary

Version of Borg

1.4.0

Logs

No response

ThomasWaldmann avatar Oct 18 '24 17:10 ThomasWaldmann

Can't reproduce this one either. 😬 Must be some specific condition.

Screenshot 2024-10-18 at 19 20 57

m3nu avatar Oct 18 '24 18:10 m3nu

I suspect this is because of a yet missing setting in my config. Once you touch/toggle it, the settings get written/initialized and from that on it is ok.

But it should be also ok when upgrading from an older vorta that did not have that setting yet.

ThomasWaldmann avatar Oct 18 '24 19:10 ThomasWaldmann

OK. Will check if there is any dependency on default settings.

m3nu avatar Oct 18 '24 19:10 m3nu

Interesting. I made a backup, maybe also restarted vorta and now I get this again:

Screenshot 2024-10-18 at 21 29 31

So the value selection is disabled, again. So guess that does not confirm my theory from previous post.

ThomasWaldmann avatar Oct 18 '24 19:10 ThomasWaldmann

I can also reproduce this for vorta built from master branch: after starting vorta, the values are not enabled.

ThomasWaldmann avatar Oct 18 '24 20:10 ThomasWaldmann

I think in SchedulePage, populate_from_profile needs to be called after the connections are set up.

ThomasWaldmann avatar Oct 18 '24 20:10 ThomasWaldmann

That's possible. Our GSoC student did some refactoring in this tab to split it into multiple components. Wouldn't be surprised to see a small bug here and there.

m3nu avatar Oct 18 '24 20:10 m3nu

Added a PR for this. Does just moving the populate_from_profile() fix it?

m3nu avatar Oct 20 '24 12:10 m3nu