vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Slow Extract Dialog

Open eitopomar opened this issue 1 year ago • 9 comments

Description

I think I encountered a bug. When I try to restore ("Extract...") a backup vorta tells me that it is "Getting archive content..." and that's it. It says "Done getting archive content." but nothing more happens. And if I try to close Vorta (from the menu bar) it crashes and I have to force quit it. The backups themselves run fine.

Reproduction

  • [X] I tried to reproduce the issue.
  • [X] I was able to reproduce the issue.

OS

MacOS Sonoma 14.5

Version of Vorta

0.9.1

What did you install Vorta with?

Homebrew

Version of Borg

1.2.7

Logs

2024-10-10 21:03:44,080 - vorta.i18n - DEBUG - Loading translation succeeded for ['en-CH', 'en-Latn-CH', 'de-CH', 'de-Latn-CH', 'it-CH', 'it-Latn-CH'].
2024-10-10 21:03:44,083 - vorta.scheduler - WARNING - Failed to connect to DBUS interface to detect sleep/resume events
2024-10-10 21:03:44,242 - root - DEBUG - Not a private SSH key file: .DS_Store
2024-10-10 21:03:44,263 - vorta.views.source_tab - DEBUG - Added item number 0 from 1
2024-10-10 21:03:44,264 - vorta.views.source_tab - DEBUG - Added item number 1 from 2
2024-10-10 21:03:44,820 - root - INFO - Using DarwinNetworkStatus NetworkStatusMonitor implementation.
2024-10-10 21:03:44,921 - vorta.borg.jobs_manager - DEBUG - Add job for site default
2024-10-10 21:03:44,921 - vorta.borg.jobs_manager - DEBUG - Start job on site: default
2024-10-10 21:03:44,922 - vorta.borg.borg_job - INFO - Running command /Applications/Vorta.app/Contents/Resources/borg-dir/borg.exe --version
2024-10-10 21:03:45,432 - vorta.borg.jobs_manager - DEBUG - Finish job for site: default
2024-10-10 21:03:45,432 - vorta.borg.jobs_manager - DEBUG - No more jobs for site: default
2024-10-10 21:03:50,550 - vorta.scheduler - DEBUG - Refreshing all scheduler timers
2024-10-10 21:03:50,552 - vorta.scheduler - INFO - Setting timer for profile 1
2024-10-10 21:03:50,553 - vorta.scheduler - DEBUG - Scheduling next run for 2024-10-10 21:47:18.721855
2024-10-10 21:05:08,928 - vorta.keyring.abc - DEBUG - No module named 'secretstorage'
2024-10-10 21:05:08,928 - vorta.keyring.abc - DEBUG - Using VortaDarwinKeyring
2024-10-10 21:05:08,928 - vorta.borg.borg_job - DEBUG - Using VortaDarwinKeyring keyring to store passwords.
2024-10-10 21:05:08,952 - vorta.keyring.darwin - DEBUG - Retrieved password for repo ssh://hetzner/home/macbookjan
2024-10-10 21:05:08,963 - vorta.borg.jobs_manager - DEBUG - Add job for site 1
2024-10-10 21:05:08,963 - vorta.borg.jobs_manager - DEBUG - Start job on site: 1
2024-10-10 21:05:08,964 - vorta.borg.borg_job - INFO - Running command /Applications/Vorta.app/Contents/Resources/borg-dir/borg.exe list --info --log-json --json-lines --format {mode}{user}{group}{size}{isomtime}{path}{source}{health}{NL} ssh://hetzner/home/macbookjan::Jans-MBP-2024-10-10-205721
2024-10-10 21:05:21,225 - vorta.borg.jobs_manager - DEBUG - Finish job for site: 1
2024-10-10 21:05:21,225 - vorta.borg.jobs_manager - DEBUG - No more jobs for site: 1
2024-10-10 21:05:21,226 - vorta.scheduler - INFO - Setting timer for profile 1
2024-10-10 21:05:21,227 - vorta.scheduler - DEBUG - Scheduling next run for 2024-10-10 21:47:18.721855

eitopomar avatar Oct 10 '24 19:10 eitopomar

I can also reproduce this on M3. Will look into it.

m3nu avatar Oct 10 '24 20:10 m3nu

Actually it doesn't fail. It just takes some time to parse the list of files. After about a minute it opened fine. This archive has about 1/4m files.

I would suggest to first change the text to mention "Building file list" or something. And then try to optimize the loading part.

m3nu avatar Oct 10 '24 20:10 m3nu

Hmm. The size of my backup is about 60 GiB. At the moment I have a rather slow internet connection. I waited for at least 10 minutes, but it still didn't open any files.

eitopomar avatar Oct 11 '24 08:10 eitopomar

It's more about the number of files to process than their size.

m3nu avatar Oct 11 '24 09:10 m3nu

The folder I backup has around 25k files.

If I use borg (borg list ssh://hetzner:23/./macbookjan::Jans-MBP-2024-10-11-110105) it works perfect and takes around 5s to list all files of the backup.

Edit: typo

eitopomar avatar Oct 11 '24 09:10 eitopomar

You can try the latest release, which has an Arm version attached. It's considerably faster on Apple Silicon than the Intel build we had before:

https://github.com/borgbase/vorta/releases/tag/v0.10.0-beta1

m3nu avatar Oct 18 '24 15:10 m3nu

My archive has several million files (est.) and it took 10 minutes to show the extract dialog for me:

    PID USER      PR  NI    VIRT    RES   SWAP    SHR S  %CPU  %MEM     TIME+ COMMAND
2124847 root      20       16.6g  15.4g         40060 S        24.6  10:27.82 /usr/bin/python3 /usr/bin/vorta

(Had to sudo vorta as I'm backing up /.)

The memory is not immediately freed after I close the extract window. Not sure if it's because of how python works though (marked as freed but not released to system yet).

HarukaMa avatar Oct 29 '24 01:10 HarukaMa

You can try the latest release, which has an Arm version attached. It's considerably faster on Apple Silicon than the Intel build we had before:

https://github.com/borgbase/vorta/releases/tag/v0.10.0-beta1

Thank you very much, this version works flawlessly

eitopomar avatar Oct 29 '24 09:10 eitopomar

Looks like this issue still persists on latest version (Vorta 0.10.1, Borg 1.4, Intel mac, Sonoma 14.7):

After "Getting archive content" it states "Done getting archive content." but it takes quite a while until the extract dialog appears (w/o any indication on the Vorta main window)

EDIT: Just realized that it states "Processing archive content" in a separate log window which is helpful knowing that there are still running tasks. Maybe makes sense to not use two different places where log/status information are displayed?

johanneshiry avatar Nov 17 '24 13:11 johanneshiry