vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Passing `--list` to `borg create` does not cause added or modified files to be listed in the vorta log.

Open LeoniePhiline opened this issue 1 year ago • 6 comments

Description

This is a follow-up to https://github.com/borgbase/vorta/discussions/984#discussioncomment-9022445.

Passing --list to borg create does not cause added or modified files to be listed in the vorta log.

I was able to reproduce the issue.

Configure "Extra arguments" with --list, optionally also with --stats:

image

Create a new backup.

Then check the logs.

Result: There's no --list or --stats output in the logs.

Expected: Detailed logs which I can search in and filter on, to verify or correct my configured exclusion patterns.

Environment

  • OS: OpenSUSE Tumbleweed
  • Vorta version: 0.9.1
  • Installed from: OpenSUSE repositories
  • Borg version: 1.2.7

Logs

See https://github.com/borgbase/vorta/discussions/984#discussioncomment-8995189

image

The logs look the same also without --dry-run.

LeoniePhiline avatar Apr 05 '24 15:04 LeoniePhiline

Me too! :-) Using Vorta 9.1. with borg 1.2.7 installed via pip.

The following command is in the logs when I create a backup: 2024-04-05 17:12:54,147 - vorta.borg.borg_job - INFO - Running command /usr/bin/borg create --list --progress --info --log-json --json --filter=AM -C lz4 ssh://[email protected]:22/~/backup/vorta_repo_test1::rep-2024-04-05-171254 /home/goebbe/test

The options --list --progress --info --log-jason --joson --filter=AM have not been added manually be me - but seem to be added by Vorta. If I understand correctly these options should result in a detailed output - however the output is not displayed in the logs of Vorta.

To test this I added a new file to my testfolder and ran a backup manually.

goebbe avatar Apr 05 '24 15:04 goebbe

Yes, we need --list to show changed files in the status bar.

m3nu avatar Apr 07 '24 06:04 m3nu

Hi, thanks for your response! 😊

You added the label “question”, but maybe based upon a misunderstanding?

I believe that the borg output should be redirected into the log file, for the log to be useful at all to debug backup issues.

The borg output missing in the logs is therefore something I personally would consider a bug.

(If you disagree about this being a big, could you then consider regarding this as a feature request, rather than a question?)

LeoniePhiline avatar Apr 07 '24 09:04 LeoniePhiline

Sending all files to the log will produce a very large log file, so I wouldn't want to do that.

m3nu avatar Apr 07 '24 16:04 m3nu

At the moment even adding the --list option explicitly, as an additional borg argument does not result in the requested output. One hackish solution would be to treat the borg output differently, when --list is added as an additional borg argument. However this might cause some confusion, since Vora adds the --list option internally in any case. So why adding --list explicitly, when it is already added by Vorta (as can be seen in the Vorta logs)?

What about adding the option: "write complete borg output to the logs", which could be off by default? The option could be added to the Settings/ about pane - where Vorta puts the links to the log-files.

goebbe avatar Apr 08 '24 06:04 goebbe

What about adding the option: "write complete borg output to the logs", which could be off by default? The option could be added to the Settings/ about pane - where Vorta puts the links to the log-files.

I find this to be a very useful solution.

LeoniePhiline avatar Apr 09 '24 18:04 LeoniePhiline