vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Error message overflows window

Open DougInAMug opened this issue 1 year ago • 10 comments

Description

A failed backup lead to an error message long enough to overflow the window. No scroll bar was available, so reading was only possible by dragging window partially off the top of the screen, then enlarging the window.

Screenshot from 2024-03-21 14-24-56

Reproduction

  • [X] I tried to reproduce the issue.
  • [X] I was able to reproduce the issue.

OS

Pop!_OS 22.04 LTS, GNOME 42.9

Version of Vorta

0.8.3

What did you install Vorta with?

Distribution package

Version of Borg

1.2.0

Logs

No response

DougInAMug avatar Mar 21 '24 13:03 DougInAMug

Yes, could be solved better. And we already do some output parsing and could catch this and treat it differently.

We should first see how we want to solve it. Maybe as larger window, similar to Vorta's own exceptions.

m3nu avatar Mar 21 '24 15:03 m3nu

Yes, could be solved better. And we already do some output parsing and could catch this and treat it differently.

We should first see how we want to solve it. Maybe as larger window, similar to Vorta's own exceptions.

Vorta's own exceptions could serve well. But what would be the best ways to catch exceptions outside of the Vorta's main thread?

This could be a good addition to my projects ('Error handling & report wizard' one). What do you think?

SAMAD101 avatar Mar 24 '24 17:03 SAMAD101

We should first see how we want to solve it. Maybe as larger window, similar to Vorta's own exceptions.

We can show a few lines and add a Read More button, which would open a scrollable window with all the details.

shivansh02 avatar Mar 26 '24 14:03 shivansh02

@m3nu Should I remove the error from here and just open an exception box as done in #1977?

shivansh02 avatar Mar 31 '24 14:03 shivansh02

Yes, I would use the same error box for Vorta AND Borg exceptions. Even if their content will be a bit different and the source they come from.

m3nu avatar Apr 01 '24 11:04 m3nu

Sure, will take this up as soon as I'm done with my proposal submission.

shivansh02 avatar Apr 01 '24 11:04 shivansh02