vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Invalidate `smb://` URLs #1631

Open TheLazron opened this issue 1 year ago • 1 comments
trafficstars

Description

Added logic from borg that validates the url against certain regex patterns. Borg code wont invalidate smb:// urls, so introduced change to one of the regex patterns

Related Issue

#1631

Motivation and Context

Additional check for Repository URL, as using smb:// format resulted in crashes as per #1628

How Has This Been Tested?

using smb:// repository URLs gave an error like other unsupported ones

Screenshots (if appropriate):

a

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] I have read the CONTRIBUTING guide.
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

TheLazron avatar Mar 06 '24 13:03 TheLazron

Why was Vorta freezing in the fist case? Is there no simpler solution to fixing that? This PR introduces quite some lines of code that need to be maintained. Additionally you do not have the copyright for these lines so proper attribution and license compatibility have to be checked.

real-yfprojects avatar Apr 01 '24 12:04 real-yfprojects