vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Improved exception dialog with copy & paste or direct error reporting

Open ThomasWaldmann opened this issue 2 years ago • 12 comments

Description

When Vorta crashed due to a python exception, one gets a dialogue box telling that one shall report the issue.

Problems:

  • copy and paste does not work from there, so one has to manually type the whole stuff one is seeing in that box.
  • the dialogue box contents are rather ugly / badly formatted

Environment

  • OS: macOS Ventura
  • Vorta version: 0.9.1beta3
  • Installed from: .dmg binary download
  • Borg version: 1.2.6

ThomasWaldmann avatar Nov 30 '23 17:11 ThomasWaldmann

It can also be found in vorta.log:

2023-11-30 17:53:38,412 - root - CRITICAL - Uncaught exception, file a report at https://github.com/borgbase/vorta/issues/new/choose
Traceback (most recent call last):
  File "views/exclude_dialog.py", line 266, in custom_pattern_editing_finished
AttributeError: 'NoneType' object has no attribute 'text'

Wondering if including the full traceback would make that more useful?

ThomasWaldmann avatar Nov 30 '23 17:11 ThomasWaldmann

Yes, this dialog could be nice. It's dealt with centrally, so should be simple enough to reformat it.

IIRC this was an idea for GSoC, but wasn't picked up in the end.

m3nu avatar Dec 01 '23 12:12 m3nu

I can't find an open issue for this, so let's track it here. This is what I imagined for errors. Maybe this can be POSTed to a Github issue from the dialog?

crashreport1

m3nu avatar Dec 01 '23 12:12 m3nu

@ThomasWaldmann @m3nu could you please assign this issue to me , would like to work on this.

rai-ankur avatar Jan 01 '24 14:01 rai-ankur

@rai-ankur Assigned - thanks for helping!

ThomasWaldmann avatar Jan 01 '24 14:01 ThomasWaldmann

@rai-ankur Please share mockups before implementing the GUI. Also if you run into problems, feel free to ask.

real-yfprojects avatar Jan 05 '24 17:01 real-yfprojects

@ThomasWaldmann @m3nu Can I work on this? I think the GUI can look like this. Screenshot from 2024-03-17 21-57-08

AdwaitSalankar avatar Mar 16 '24 21:03 AdwaitSalankar

Looks good! I would suggest adding a copy button though.

shivansh02 avatar Mar 18 '24 04:03 shivansh02

@rai-ankur You don't work on this any more, right?

ThomasWaldmann avatar Mar 18 '24 11:03 ThomasWaldmann

@AdwaitSalankar Personally, I would rather have copy&paste than "send this report directly to Github" (and any complexity relating to the latter).

ThomasWaldmann avatar Mar 18 '24 11:03 ThomasWaldmann

Agreed, This would simplify things. Does this look good? Screenshot from 2024-03-19 00-42-59 The GitHub link will direct to https://github.com/borgbase/vorta/issues/new/choose

AdwaitSalankar avatar Mar 18 '24 19:03 AdwaitSalankar

I think the link should go to .../issues and it should also tell "Please only open new issues after checking if this issue was not already reported."

ThomasWaldmann avatar Mar 18 '24 22:03 ThomasWaldmann