Vorta loads endlessly on Borg User Input

[Bungeefan]

trafficstars

Description

In case Borg waits for a user input, for example before connecting to an unknown unencrypted repository, Vorta never indicates this nor finished its job.

I happened to have such a situation by importing a profile which pointed to a repository that was yet unknown to Borg and Vorta hang forever at "Refreshing archives". The job canceling in the logs down below, was me hitting "Cancel" after some time.

Manually answering the user input via terminal solves the problem for Vorta, however, it took quite some time to pinpoint it to this issue.

Reproduction

1. Create a Borg repository that waits for any user input when accessing it via native Borg commands. (e.g. borg list to an unknown unencrypted repo)
2. Import (or possibly create) a profile that uses this repository.
3. I guess any action on the repository would result in the same situation, however, I clicked "Refresh archives". (the sync icon button under the archives list)
4. Vorta hangs forever as Borg waits for the user input before continuing. (Canceling works, but a retry has the same fate)

Reproduction

• [X] I tried to reproduce the issue.
• [X] I was able to reproduce the issue.

OS

Linux 6.5.5-1-MANJARO, KDE Plasma 5.27.8

Version of Vorta

0.8.12

What did you install Vorta with?

Other

Version of Borg

1.2.6

Logs

2023-10-02 01:01:32,007 - vorta.keyring.abc - DEBUG - Only available on macOS
2023-10-02 01:01:32,007 - vorta.keyring.abc - DEBUG - Using VortaKWallet5Keyring
2023-10-02 01:01:32,008 - vorta.borg.borg_job - DEBUG - Using VortaKWallet5Keyring keyring to store passwords.
2023-10-02 01:01:32,008 - vorta.borg.borg_job - DEBUG - Password not found in primary keyring. Falling back to VortaDBKeyring.
2023-10-02 01:01:32,015 - vorta.borg.jobs_manager - DEBUG - Add job for site 3
2023-10-02 01:01:32,015 - vorta.borg.jobs_manager - DEBUG - Start job on site: 3
2023-10-02 01:01:32,024 - vorta.borg.borg_job - INFO - Running command /usr/bin/borg list --info --log-json --json ssh://<redacted>
2023-10-02 01:03:46,148 - vorta.borg.borg_job - DEBUG - Cancel job on site default
2023-10-02 01:03:46,148 - vorta.borg.borg_job - DEBUG - Cancel job on site 1
2023-10-02 01:03:46,148 - vorta.borg.borg_job - DEBUG - Cancel job on site 2
2023-10-02 01:03:46,148 - vorta.borg.borg_job - DEBUG - Cancel job on site 3
2023-10-02 01:03:49,148 - vorta.borg.jobs_manager - INFO - Finished cancelling all jobs
2023-10-02 01:03:49,151 - vorta.borg.borg_job - ERROR - Connection closed by remote host
2023-10-02 01:03:49,272 - vorta.borg.jobs_manager - DEBUG - Finish job for site: 3
2023-10-02 01:03:49,272 - vorta.borg.jobs_manager - DEBUG - No more jobs for site: 3

[real-yfprojects]

Thank you for you bug report this should be fixed. However I am still unsure whether Vorta should show an error message in these cases or open window where the user can answer the input requests.

[Bungeefan]

Nice, thanks for fixing it!

Sorry for the long delay, I think an error would be fine, however, a nice input window to be able to directly resolve the issue could be really nice too. On the other side, this may be superfluous for the most part, as AFAIK there aren't many warnings that should be resolved via a direct input (thinking about security warnings). I would say this depends heavily on the type of user you are targeting with Vorta (power user vs. casual user).

What is the current fix/behavior?