vorta icon indicating copy to clipboard operation
vorta copied to clipboard

The UI for adding new repo is very confusing

Open mxj4 opened this issue 2 years ago • 1 comments

Description

There is no problem using local repo for backup, but when using a remote repo, the correct steps are usually:

  1. Go to the remote server to create new repo
  2. Go to Vorta and click New Repository ... button when the other option in the combobox is Existing Repository ...

Since the user just created a new repo from borgbase.com, it's very confusing here and usually user will click Existing Repository ... button. Then they will get an error in log saying ?"Repository is invalid, check the config".

If we have an explicit Remote repo first-time setup button, it would be less confusing. Alternatively, Vorta could fallback to repo init UI after seeing repo invalid error.

Reproduction

  • [X] I tried to reproduce the issue.
  • [ ] I was able to reproduce the issue.

OS

Linux

Version of Vorta

all

What did you install Vorta with?

Flatpak

Version of Borg

1.2.4

Logs

2023-08-20 20:41:37,465 - vorta.keyring.abc - DEBUG - Only available on macOS
2023-08-20 20:41:37,473 - asyncio - DEBUG - Using selector: EpollSelector
2023-08-20 20:41:37,475 - vorta.keyring.abc - DEBUG - Using VortaSecretStorageKeyring
2023-08-20 20:41:37,475 - vorta.borg.borg_job - DEBUG - Using VortaSecretStorageKeyring keyring to store passwords.
2023-08-20 20:41:37,477 - asyncio - DEBUG - Using selector: EpollSelector
2023-08-20 20:41:37,479 - vorta.keyring.secretstorage - DEBUG - Found 0 passwords matching repo URL.
2023-08-20 20:41:37,480 - vorta.borg.borg_job - DEBUG - Password not found in primary keyring. Falling back to VortaDBKeyring.
2023-08-20 20:41:37,558 - vorta.borg.borg_job - INFO - Running command /app/bin/borg info --info --json --log-json ssh://[email protected]/./repo
2023-08-20 20:41:42,345 - vorta.borg.borg_job - ERROR - /srv/repos/xxx/repo is not a valid repository. Check repo config.

mxj4 avatar Aug 21 '23 05:08 mxj4

  • Go to Vorta and click New Repository ... button when the other option in the combobox is Existing Repository ...

This distinction is made because New Repository... will run borg init and Existing Repository will only run borg info to check whether the repository actually exists. When creating a repository on borgbase the repository isn't actually initialized. The client has to initialize it because the client generates and stores the encryption key.

I therefore think this distinction makes sense and provides a good UX. However I do see that novice user might confuse these two options. Therefore I am interested if you have an idea to make this distinction more clear.

If we have an explicit Remote repo first-time setup button

IMO adding more options doesn't simplify things but often makes it more confusing.

Alternatively, Vorta could fallback to repo init UI after seeing repo invalid error.

That is a good idea. Something like that could be implemented.

real-yfprojects avatar Aug 23 '23 11:08 real-yfprojects

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 09 '24 02:04 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Apr 16 '24 02:04 github-actions[bot]