vorta
vorta copied to clipboard
borgbase
Edit repository dialog
Why not instead of a completely new popup for only the password change, the UI be more like the "initialize new backup repository" and allow editing the repository itself?
Originally posted by @eSoares in https://github.com/borgbase/vorta/issues/303#issuecomment-1472865381
Moving this to a new issue as asked by @real-yfprojects
We can create a new menu and put config options there. I like the first option where we can keep passphrase change and edit repo options seperately but we can also create tab in edit dialog and put passphrase option there (image 2; ignore eye icon) as suggested by @eSoares .
How does it look?
Looking good! When changing the path of the repo, the user can enter a path to any repo. How would vorta handle this?
I'd need to research more on this but on surface level changing path is similar to unlinking then adding existing repo. So vorta would need to
- validate the path
- check if it already exists
- modify url and refresh
Is this missing anything?
So why do we need this then if it behaves exactly like adding an existing repo?
I also don't see much value in editing the repo path, except to introduce many chances for errors. Many things, like list of archives is done around repos. If the repo URL changes, it's not clear at first if this is a new or known repo.
It's also irrelevant for remote repos.
And finally, Borg can get upset when it finds a known repo in a new place. This can trigger prompts we can't handle yet.
I think resources are better invested in other issues. E.g. having names for repos would be nice. And selecting multiple repos per profile. Both already have open issues, I believe.
Makes sense. What about extra borg argument field?
We already have an entry for extra arguments that only applies to create. These two should be grouped together I think.
@real-yfprojects Sorry not sure what you are referring to. Can you point me to code?
@real-yfprojects Sorry not sure what you are referring to. Can you point me to code?
https://github.com/borgbase/vorta/blob/1f1278270df5dd452ffaa3646912f2520387a9c7/src/vorta/views/schedule_tab.py#L84-L86
This escaped my radar. It makes sense to group them together or at very least adding field to edit borg arguments there. I can work on it as soon as we finalise the design.
If something like a Edit repository dialog will be implemented another possible field could be the
"Repository Name"
In Vorta 9.1., I didn't find a way to edit/ change the "Repository Name", from the UI.
Since repositories aren't assigned a specific profile but can be used in multiple or none at all, I suggest adding a tab to the settings view listing all the repositories added in Vorta with the option to edit their name, their password and their extra borg arguments.